Re: Xcb - Setting the WM_TRANSIENT_FOR property on a window

by Peter Harrison 2010-03-22T13:05:18+00:00
On Mon, Mar 22, 2010 at 8:19 AM, Arnaud Fontaine wrote:
I see you've used variable length arrays. A few points spring to mind:
- Variable-length arrays are C99. The Microsoft C compilers still
don't support most of C99.
- Variable-length arrays are merely a portable way to spell "alloca".
The server folks have just recently (2007) removed all allocas from
the server. There is no portable way to determine the amount of stack
space available, and alloca rarely returns NULL (and variable-length
arrays can't). This matters less in a client side library, since you
can only DoS yourself.
- Making an extra copy is no fun. XCB uses iovecs to try to avoid
extra copies. You'd have to open-code ChangeProperty to use an iovec,
though, which is ugly. Thoughts?
My comments above are just things I thought of, and not deep
complaints. Feel free to commit if nobody else objects.
Peter Harris

Conversations: Xcb - Setting the WM_TRANSIENT_FOR property on a window